Checkstyle Results
The following document contains the results of
Checkstyle
.
Summary
| Files | Infos | Warnings | Errors |
|---|
| 39 | 0 | 0 | 268 |
Files
com/webstersmalley/picweb/online/bus/Category.java
| Error | Line |
|---|
| Line does not match expected header line of 'Apache License'. |
1
|
|
| Missing a Javadoc comment. |
24
|
|
| Missing a Javadoc comment. |
25
|
|
| Missing a Javadoc comment. |
27
|
|
| Missing a Javadoc comment. |
29
|
|
| Missing a Javadoc comment. |
31
|
|
| Missing a Javadoc comment. |
33
|
|
| Method 'setPictures' is not designed for extension - needs to be abstract, final or empty. |
39
|
|
| Parameter pictures should be final. |
39
|
|
| 'pictures' hides a field. |
39
|
|
| Method 'setSubcategories' is not designed for extension - needs to be abstract, final or empty. |
47
|
|
| Parameter subcategories should be final. |
47
|
|
| 'subcategories' hides a field. |
47
|
|
| Method 'getDescription' is not designed for extension - needs to be abstract, final or empty. |
54
|
|
| Method 'setDescription' is not designed for extension - needs to be abstract, final or empty. |
62
|
|
| Parameter description should be final. |
62
|
|
| 'description' hides a field. |
62
|
|
| Method 'getId' is not designed for extension - needs to be abstract, final or empty. |
69
|
|
| Method 'setId' is not designed for extension - needs to be abstract, final or empty. |
77
|
|
| Parameter id should be final. |
77
|
|
| 'id' hides a field. |
77
|
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
84
|
|
| Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
92
|
|
| Parameter name should be final. |
92
|
|
| 'name' hides a field. |
92
|
|
| Method 'getSubcategories' is not designed for extension - needs to be abstract, final or empty. |
96
|
|
| Missing a Javadoc comment. |
96
|
|
| Method 'getPictures' is not designed for extension - needs to be abstract, final or empty. |
100
|
|
| Missing a Javadoc comment. |
100
|
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
104
|
|
| Missing a Javadoc comment. |
104
|
com/webstersmalley/picweb/online/bus/CategoryAdminValidator.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Missing a Javadoc comment. |
27
|
|
| Missing a Javadoc comment. |
29
|
|
| Missing a Javadoc comment. |
31
|
|
| Method 'getCategoryManager' is not designed for extension - needs to be abstract, final or empty. |
36
|
|
| Method 'setCategoryManager' is not designed for extension - needs to be abstract, final or empty. |
44
|
|
| Parameter categoryManager should be final. |
44
|
|
| 'categoryManager' hides a field. |
44
|
|
| Method 'supports' is not designed for extension - needs to be abstract, final or empty. |
48
|
|
| Missing a Javadoc comment. |
48
|
|
| Parameter clazz should be final. |
48
|
|
| Method 'validate' is not designed for extension - needs to be abstract, final or empty. |
52
|
|
| Missing a Javadoc comment. |
52
|
|
| Parameter obj should be final. |
52
|
|
| Parameter errors should be final. |
52
|
|
| Must have at least one statement. |
63
|
com/webstersmalley/picweb/online/bus/CategoryManager.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Missing a Javadoc comment. |
25
|
|
| Missing a Javadoc comment. |
26
|
|
| Redundant 'public' modifier. |
26
|
|
| Missing a Javadoc comment. |
28
|
|
| Redundant 'public' modifier. |
28
|
|
| Missing a Javadoc comment. |
30
|
|
| Redundant 'public' modifier. |
30
|
|
| Redundant throws: 'DataAccessException' is unchecked exception. |
30
|
|
| Missing a Javadoc comment. |
32
|
|
| Redundant 'public' modifier. |
32
|
|
| Missing a Javadoc comment. |
34
|
|
| Redundant 'public' modifier. |
34
|
|
| Missing a Javadoc comment. |
36
|
|
| Redundant 'public' modifier. |
36
|
com/webstersmalley/picweb/online/bus/CategoryManagerImpl.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Missing a Javadoc comment. |
27
|
|
| Missing a Javadoc comment. |
28
|
|
| Method 'setCategoryDao' is not designed for extension - needs to be abstract, final or empty. |
30
|
|
| Missing a Javadoc comment. |
30
|
|
| Parameter categoryDao should be final. |
30
|
|
| 'categoryDao' hides a field. |
30
|
|
| Line has trailing spaces. |
36
|
|
| Line is longer than 80 characters. |
37
|
|
| Method 'createAndStoreCategory' is not designed for extension - needs to be abstract, final or empty. |
40
|
|
| Missing a Javadoc comment. |
40
|
|
| Parameter cat should be final. |
40
|
|
| Line has trailing spaces. |
46
|
|
| Line is longer than 80 characters. |
47
|
|
| Method 'getCategory' is not designed for extension - needs to be abstract, final or empty. |
49
|
|
| Missing a Javadoc comment. |
49
|
|
| Parameter name should be final. |
49
|
|
| Line has trailing spaces. |
55
|
|
| Method 'loadCategories' is not designed for extension - needs to be abstract, final or empty. |
58
|
|
| Missing a Javadoc comment. |
58
|
|
| Redundant throws: 'DataAccessException' is unchecked exception. |
58
|
|
| Method 'getRootCategories' is not designed for extension - needs to be abstract, final or empty. |
62
|
|
| Missing a Javadoc comment. |
62
|
|
| Method 'getSubcategories' is not designed for extension - needs to be abstract, final or empty. |
66
|
|
| Missing a Javadoc comment. |
66
|
|
| Parameter cat should be final. |
66
|
|
| Method 'getCategory' is not designed for extension - needs to be abstract, final or empty. |
70
|
|
| Missing a Javadoc comment. |
70
|
|
| Parameter id should be final. |
70
|
com/webstersmalley/picweb/online/bus/CategoryNotFoundException.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Missing a Javadoc comment. |
21
|
com/webstersmalley/picweb/online/bus/Picture.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Missing a Javadoc comment. |
21
|
|
| Missing a Javadoc comment. |
23
|
|
| Missing a Javadoc comment. |
25
|
|
| Missing a Javadoc comment. |
27
|
|
| Method 'getDescription' is not designed for extension - needs to be abstract, final or empty. |
32
|
|
| Method 'setDescription' is not designed for extension - needs to be abstract, final or empty. |
40
|
|
| Parameter description should be final. |
40
|
|
| 'description' hides a field. |
40
|
|
| Method 'getId' is not designed for extension - needs to be abstract, final or empty. |
47
|
|
| Method 'setId' is not designed for extension - needs to be abstract, final or empty. |
55
|
|
| Parameter id should be final. |
55
|
|
| 'id' hides a field. |
55
|
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
62
|
|
| Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
70
|
|
| Parameter name should be final. |
70
|
|
| 'name' hides a field. |
70
|
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
74
|
|
| Missing a Javadoc comment. |
74
|
com/webstersmalley/picweb/online/bus/TestApp.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'Apache License'. |
1
|
|
| Unused import - com.webstersmalley.picweb.online.db.HsqlUtils. |
27
|
|
| Missing a Javadoc comment. |
29
|
|
| Utility classes should not have a public or default constructor. |
29
|
|
| Missing a Javadoc comment. |
31
|
|
| Parameter args should be final. |
31
|
com/webstersmalley/picweb/online/bus/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
com/webstersmalley/picweb/online/db/CategoryDao.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Missing a Javadoc comment. |
25
|
|
| Missing a Javadoc comment. |
26
|
|
| Redundant 'public' modifier. |
26
|
|
| Missing a Javadoc comment. |
28
|
|
| Redundant 'public' modifier. |
28
|
|
| Missing a Javadoc comment. |
30
|
|
| Redundant 'public' modifier. |
30
|
|
| Missing a Javadoc comment. |
32
|
|
| Redundant 'public' modifier. |
32
|
|
| Missing a Javadoc comment. |
34
|
|
| Redundant 'public' modifier. |
34
|
com/webstersmalley/picweb/online/db/CategoryDaoHibernate.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
com/webstersmalley/picweb/online/db/CategoryDaoHibernate.java
| Error | Line |
|---|
|
| Line does not match expected header line of 'Apache License'. |
1
|
|
| Unused import - org.springframework.dao.DataAccessException. |
26
|
|
| Missing a Javadoc comment. |
33
|
|
| Missing a Javadoc comment. |
36
|
|
| Method 'setPictureDao' is not designed for extension - needs to be abstract, final or empty. |
38
|
|
| Missing a Javadoc comment. |
38
|
|
| Parameter pictureDao should be final. |
38
|
|
| 'pictureDao' hides a field. |
38
|
|
| Method 'loadCategories' is not designed for extension - needs to be abstract, final or empty. |
42
|
|
| Missing a Javadoc comment. |
42
|
|
| Method 'getCategory' is not designed for extension - needs to be abstract, final or empty. |
46
|
|
| Missing a Javadoc comment. |
46
|
|
| Parameter name should be final. |
46
|
|
| Method 'createAndStoreCategory' is not designed for extension - needs to be abstract, final or empty. |
62
|
|
| Missing a Javadoc comment. |
62
|
|
| Parameter cat should be final. |
62
|
|
| Method 'getCategory' is not designed for extension - needs to be abstract, final or empty. |
72
|
|
| Missing a Javadoc comment. |
72
|
|
| Parameter id should be final. |
72
|
|
| Method 'getRootCategories' is not designed for extension - needs to be abstract, final or empty. |
77
|
|
| Missing a Javadoc comment. |
77
|
com/webstersmalley/picweb/online/db/CategoryDaoJdbc.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Unused import - org.springframework.dao.DataAccessException. |
25
|
|
| Missing a Javadoc comment. |
30
|
|
| Missing a Javadoc comment. |
32
|
|
| Missing a Javadoc comment. |
34
|
|
| Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
36
|
|
| Missing a Javadoc comment. |
36
|
|
| Parameter oldName should be final. |
36
|
|
| Parameter newName should be final. |
36
|
|
| '{' is followed by whitespace. |
39
|
|
| Method 'setDataSource' is not designed for extension - needs to be abstract, final or empty. |
42
|
|
| Missing a Javadoc comment. |
42
|
|
| Parameter dataSource should be final. |
42
|
|
| 'dataSource' hides a field. |
42
|
|
| Method 'loadCategories' is not designed for extension - needs to be abstract, final or empty. |
46
|
|
| Missing a Javadoc comment. |
46
|
|
| Method 'getCategory' is not designed for extension - needs to be abstract, final or empty. |
51
|
|
| Missing a Javadoc comment. |
51
|
|
| Parameter name should be final. |
51
|
|
| Method 'createAndStoreCategory' is not designed for extension - needs to be abstract, final or empty. |
56
|
|
| Missing a Javadoc comment. |
56
|
|
| Parameter cat should be final. |
56
|
|
| '{' is followed by whitespace. |
59
|
|
| Method 'getCategory' is not designed for extension - needs to be abstract, final or empty. |
62
|
|
| Missing a Javadoc comment. |
62
|
|
| Parameter id should be final. |
62
|
|
| Method 'getRootCategories' is not designed for extension - needs to be abstract, final or empty. |
67
|
|
| Missing a Javadoc comment. |
67
|
com/webstersmalley/picweb/online/db/HsqlUtils.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Missing a Javadoc comment. |
25
|
|
| Missing a Javadoc comment. |
26
|
|
| Missing a Javadoc comment. |
28
|
|
| Method 'shutDown' is not designed for extension - needs to be abstract, final or empty. |
30
|
|
| Missing a Javadoc comment. |
30
|
|
| Method 'setDataSource' is not designed for extension - needs to be abstract, final or empty. |
37
|
|
| Missing a Javadoc comment. |
37
|
|
| Parameter dataSource should be final. |
37
|
|
| 'dataSource' hides a field. |
37
|
com/webstersmalley/picweb/online/db/PictureDao.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Missing a Javadoc comment. |
25
|
|
| Missing a Javadoc comment. |
26
|
|
| Redundant 'public' modifier. |
26
|
|
| Missing a Javadoc comment. |
28
|
|
| Redundant 'public' modifier. |
28
|
com/webstersmalley/picweb/online/db/PictureDaoHibernate.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Missing a Javadoc comment. |
26
|
|
| Method 'createAndStorePicture' is not designed for extension - needs to be abstract, final or empty. |
29
|
|
| Missing a Javadoc comment. |
29
|
|
| Parameter pic should be final. |
29
|
|
| Method 'loadPictures' is not designed for extension - needs to be abstract, final or empty. |
33
|
|
| Missing a Javadoc comment. |
33
|
com/webstersmalley/picweb/online/db/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
com/webstersmalley/picweb/online/web/BannerController.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Unused import - java.util.HashMap. |
22
|
|
| Unused import - java.util.Map. |
23
|
|
| Missing a Javadoc comment. |
34
|
|
| First sentence should end with a period. |
35
|
|
| Variable 'logger' must be private and have accessor methods. |
36
|
|
| Method 'handleRequest' is not designed for extension - needs to be abstract, final or empty. |
38
|
|
| Missing a Javadoc comment. |
38
|
|
| Parameter request should be final. |
38
|
|
| Parameter response should be final. |
39
|
com/webstersmalley/picweb/online/web/BrowserController.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Unused import - javax.servlet.http.HttpServlet. |
26
|
|
| Unused import - com.webstersmalley.picweb.online.bus.Category. |
35
|
|
| Missing a Javadoc comment. |
38
|
|
| First sentence should end with a period. |
39
|
|
| Variable 'logger' must be private and have accessor methods. |
40
|
|
| Missing a Javadoc comment. |
42
|
|
| Method 'handleRequest' is not designed for extension - needs to be abstract, final or empty. |
44
|
|
| Missing a Javadoc comment. |
44
|
|
| Parameter request should be final. |
44
|
|
| Parameter response should be final. |
45
|
|
| Method 'getCategoryManager' is not designed for extension - needs to be abstract, final or empty. |
56
|
|
| Unused @param tag for 'catMan'. |
61
|
|
| Method 'setCategoryManager' is not designed for extension - needs to be abstract, final or empty. |
64
|
|
| Parameter categoryManager should be final. |
64
|
|
| 'categoryManager' hides a field. |
64
|
|
| Expected @param tag for 'categoryManager'. |
64
|
com/webstersmalley/picweb/online/web/CategoryAdminFormController.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Missing a Javadoc comment. |
36
|
|
| First sentence should end with a period. |
37
|
|
| Variable 'logger' must be private and have accessor methods. |
38
|
|
| Missing a Javadoc comment. |
40
|
|
| Method 'onSubmit' is not designed for extension - needs to be abstract, final or empty. |
42
|
|
| Missing a Javadoc comment. |
42
|
|
| Parameter command should be final. |
42
|
|
| Method 'formBackingObject' is not designed for extension - needs to be abstract, final or empty. |
52
|
|
| Missing a Javadoc comment. |
52
|
|
| Parameter request should be final. |
52
|
|
| Method 'getCategoryManager' is not designed for extension - needs to be abstract, final or empty. |
64
|
|
| Method 'setCategoryManager' is not designed for extension - needs to be abstract, final or empty. |
72
|
|
| Parameter categoryManager should be final. |
72
|
|
| 'categoryManager' hides a field. |
72
|
com/webstersmalley/picweb/online/web/DisclaimerController.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Unused import - java.util.HashMap. |
22
|
|
| Unused import - java.util.Map. |
23
|
|
| Missing a Javadoc comment. |
34
|
|
| First sentence should end with a period. |
35
|
|
| Variable 'logger' must be private and have accessor methods. |
36
|
|
| Method 'handleRequest' is not designed for extension - needs to be abstract, final or empty. |
38
|
|
| Missing a Javadoc comment. |
38
|
|
| Parameter request should be final. |
38
|
|
| Parameter response should be final. |
39
|
com/webstersmalley/picweb/online/web/RefreshAllController.java
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Unused import - java.util.HashMap. |
22
|
|
| Unused import - java.util.Map. |
23
|
|
| Missing a Javadoc comment. |
34
|
|
| First sentence should end with a period. |
35
|
|
| Variable 'logger' must be private and have accessor methods. |
36
|
|
| Method 'handleRequest' is not designed for extension - needs to be abstract, final or empty. |
38
|
|
| Missing a Javadoc comment. |
38
|
|
| Parameter request should be final. |
38
|
|
| Parameter response should be final. |
39
|
com/webstersmalley/picweb/online/web/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
